make use of ringpop LookN method #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ast2023
commented
Nov 10, 2023
ast2023
force-pushed
the
sasha/oss-1763
branch
2 times, most recently
from
067f5c8 to
4fc6b21
Compare
dnr
reviewed
Nov 10, 2023
ast2023
force-pushed
the
sasha/oss-1763
branch
from
05002a4 to
4f005aa
Compare
|
Hey @dnr, I've uploaded a new version. I addressed most of the suggestions you pointed out. Additionally, I did some refactoring to ensure that the code better aligns with the information you provided. Let me know your thoughts! |
dnr
reviewed
Nov 15, 2023
dnr
reviewed
Nov 15, 2023
ast2023
force-pushed
the
sasha/oss-1763
branch
3 times, most recently
from
fba2f63 to
92bb47a
Compare
dnr
reviewed
Nov 16, 2023
ast2023
force-pushed
the
sasha/oss-1763
branch
2 times, most recently
from
f581fe6 to
3e26e79
Compare
dnr
reviewed
Nov 21, 2023
ast2023
force-pushed
the
sasha/oss-1763
branch
from
3e26e79 to
9bf74dd
Compare
dnr
approved these changes
Nov 27, 2023
ast2023
force-pushed
the
sasha/oss-1763
branch
from
9bf74dd to
eb31547
Compare
ast2023
force-pushed
the
sasha/oss-1763
branch
from
eb31547 to
259244a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
To find number of per namespace workers we now use ringpop LookupN method instead of sequentially calling Lookup. The lookup key also changed: worker id was dropped from the hashed string.
Added util.SliceMap function and renamed util.SliceReduce to util.SliceFold
Why?
more evenly distribute work across ring
How did you test it?
local testing only
Potential risks
not sure
Is hotfix candidate?
no